Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Add basic suppoort for php 8.3 #35

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

xvilo
Copy link
Contributor

@xvilo xvilo commented Nov 2, 2023

Add basic support for PHP 8.3, when running the test suite locally all tests are passing

Signed-off-by: Sem Schilder <[email protected]>
@xvilo xvilo force-pushed the update/php-83-support branch from 8eed144 to fa7d5b0 Compare November 2, 2023 10:54
@xvilo
Copy link
Contributor Author

xvilo commented Nov 2, 2023

I see there are some unrelated linting steps failing, does the project expect me to fix them or can we leave them as is?

@gsteel
Copy link
Member

gsteel commented Nov 2, 2023

@xvilo
It would be great if you could get CI green here. There are a bunch of trailing spaces in the README and some extra blank lines - If you could trim those as per the error messages here:
https://github.com/laminas/laminas-mime/actions/runs/6731571212/job/18296531885?pr=35#step:3:218

… it would be very much appreciated, and it would fix CI for both Docs and README linting jobs.

@gsteel gsteel added this to the 2.12.0 milestone Nov 2, 2023
@gsteel gsteel self-assigned this Nov 2, 2023
@xvilo
Copy link
Contributor Author

xvilo commented Nov 2, 2023

@gsteel It seems the README linting issues are resolved with my latest commit. However, the Autocloser / autoclose job is still failing because of a missing token. I expect this to not be an issue, but I have no clear idea on what it does.

Please do let me know this also needs to be addressed, otherwise I hope this can be merged 🎉

@Ocramius Ocramius assigned Ocramius and unassigned gsteel Nov 2, 2023
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xvilo!

@Ocramius Ocramius merged commit 08cc544 into laminas:2.12.x Nov 2, 2023
@xvilo
Copy link
Contributor Author

xvilo commented Nov 2, 2023

Thanks, @Ocramius, that was fast ❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants